Skip to content

fix: allow flag resolver to handle get variant flag enabled better #10951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomasheartman wants to merge 1 commit into from
Closed

fix: allow flag resolver to handle get variant flag enabled better #10951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/util/flag-resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default class FlagResolver implements IFlagResolver {
const exp = this.experiments[expName];
if (exp) {
if (typeof exp === 'boolean') return exp;
else if (exp.enabled) return exp.enabled;
else if (exp.enabled || exp.feature_enabled) return true;
Copy link
Contributor

@kwasniew kwasniew Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int he experimental.file we have enabled not feature_enabled. I was adding this line here: #10607

Copy link
Contributor

@kwasniew kwasniew Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. this is one example where we have enabled field only and my change was addressing what we actually do in the experimenta.ts

   streaming: {
        name: 'disabled',
        enabled: parseEnvVarBoolean(
            process.env.UNLEASH_EXPERIMENTAL_STREAMING,
            false,
        ),
    },

Copy link
Contributor Author

@thomasheartman thomasheartman Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what we do, but the type is:

export interface Variant {
    name: string;
    enabled: boolean;
    payload?: Payload;
    feature_enabled?: boolean;
}

So we still allow you to have a feature_enabled field. We just don't treat it the same way that the regular unleash client does.

}
return this.externalResolver.isEnabled(expName, context);
}
Expand Down
Loading