-
-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: filter out milestone strategies in features_view #8883
Merged
nunogois
merged 4 commits into
main
from
chore-features-view-filter-out-milestone-strategies
Dec 2, 2024
Merged
chore: filter out milestone strategies in features_view #8883
nunogois
merged 4 commits into
main
from
chore-features-view-filter-out-milestone-strategies
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
chriswk
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…trategies are still returned
nunogois
force-pushed
the
chore-features-view-filter-out-milestone-strategies
branch
from
November 29, 2024 10:36
43cf2f8
to
3b6789d
Compare
chriswk
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good. Also more honest about enabled/disabled
nunogois
deleted the
chore-features-view-filter-out-milestone-strategies
branch
December 2, 2024 08:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-3033/filter-out-release-plan-milestone-strategies-from-admin-feature
Filters out milestone strategies from our
features_view
.This felt like the most elegant way to address this, since it seems we only rely on this view to fetch the feature strategies in the admin UI.
No more milestone strategies showing up on our UI when we have a running milestone
However they're still part of the client features response