Skip to content

Conversation

@dtxe
Copy link
Member

@dtxe dtxe commented Mar 21, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

  • Rename homework problems to "practice problems" to further reduce confusion in what is assigned and graded vs optional practice

@github-actions
Copy link

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@github-actions
Copy link

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@RohanAlexander
Copy link
Member

With the conflicts - I've assumed that the second one was generally the one we wanted.

@danielrazavi Would you mind taking a quick look sometime this week please as a second reviewer please?

Copy link
Member

@danielrazavi danielrazavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me! I noticed a small dependency on @dtxe's repositories. For improved future-proofing, it might be better to transfer this dependency to our own org instead, but I defer to @RohanAlexander judgement.

Copy link
Member

@danielrazavi danielrazavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@dtxe dtxe closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants