Skip to content

Conversation

@mf72270
Copy link

@mf72270 mf72270 commented Nov 16, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@github-actions
Copy link

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

Copy link

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment 1 completed. All assignments in viz module completed.

@RohanAlexander RohanAlexander requested review from danielrazavi and xindizhang and removed request for xindizhang November 17, 2025 13:05
Copy link

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mf72270,

You submitted your pull request to the DSI repo, which is incorrect — you should be submitting to your own repository. Please follow the instructions above to close this pull request and open a new one from your personal repo.

That said, I did review your code, and everything looks good — once you submit it to the correct repo, you should be all set.

Feel free to let me know if you have any questions or need further clarification.

@xindizhang xindizhang closed this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants