[ graph ] Tangent toggle functionnality (#156) #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yaya-Cout
reviewed
Mar 11, 2022
| @@ -19,6 +19,7 @@ void GraphView::reload() { | |||
| KDRect dirtyZone(KDRect(0, 0, bounds().width(), bounds().height()-m_bannerView->bounds().height())); | |||
| markRectAsDirty(dirtyZone); | |||
| } | |||
| markRectAsDirty(bounds()); | |||
There was a problem hiding this comment.
Why are you not using the AppsContainer reload function ?
There was a problem hiding this comment.
When you use here the AppsContainer reload function, the app just crash when you enter in the graph mode ...
| if (event == Ion::Events::Up) { | ||
| m_recordDelegate->moveUp(); | ||
| m_graphView->selectRecord(m_recordDelegate->getRecord()); | ||
| // TODO maybe do: Very ugly workaround... Needs something better to reload the data banner |
There was a problem hiding this comment.
Do you try with the AppsContainer reload function ?
There was a problem hiding this comment.
Yup and it's not working (just tried xd).
|
1 similar comment
|
Yaya-Cout
reviewed
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The students can now switch between the tangents directly from the tangent's view using the up and down keys