Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ calculation ] Adding Scientific Form in the complementary outputs with exponent shift functionality (#149) #180

Draft
wants to merge 4 commits into
base: upsilon-dev
Choose a base branch
from
Draft

[ calculation ] Adding Scientific Form in the complementary outputs with exponent shift functionality (#149) #180

wants to merge 4 commits into from

Conversation

devdl11
Copy link
Member

@devdl11 devdl11 commented Mar 18, 2022 •
edited
Loading

Look the issue #149 for more details.

Tasks:

  • Create the basic system for the integers
  • Implementing the system for the others complementarities output if possible (decimal/fraction)

@devdl11 devdl11 marked this pull request as draft March 18, 2022 18:14
Yaya-Cout
Yaya-Cout reviewed Mar 18, 2022
View reviewed changes
apps/calculation/additional_outputs/integer_list_controller.cpp
@@ -47,9 +69,44 @@ I18n::Message IntegerListController::messageAtIndex(int index) {
return I18n::Message::HexadecimalBase;
case 2:
return I18n::Message::BinaryBase;
case 3:
return I18n::Message::Scientific;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix indentation ?

Suggested change
return I18n::Message::Scientific;
return I18n::Message::Scientific;

@github-actions
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 813224 bytes 442332 bytes 226896 bytes 1776 bytes 228672 bytes 1257332 bytes
Head 813664 bytes 442332 bytes 226904 bytes 1776 bytes 228680 bytes 1257772 bytes
+440 bytes +0 bytes +8 bytes +0 bytes +8 bytes +440 bytes
+0.1 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

@github-actions
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 813224 bytes 442332 bytes 226896 bytes 1776 bytes 228672 bytes 1257332 bytes
Head 813776 bytes 442332 bytes 226904 bytes 1776 bytes 228680 bytes 1257884 bytes
+552 bytes +0 bytes +8 bytes +0 bytes +8 bytes +552 bytes
+0.1 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

@github-actions
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 813224 bytes 442332 bytes 226896 bytes 1776 bytes 228672 bytes 1257332 bytes
Head 813776 bytes 442332 bytes 226904 bytes 1776 bytes 228680 bytes 1257884 bytes
+552 bytes +0 bytes +8 bytes +0 bytes +8 bytes +552 bytes
+0.1 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

@github-actions
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 813224 bytes 442332 bytes 226896 bytes 1776 bytes 228672 bytes 1257332 bytes
Head 813848 bytes 442332 bytes 226904 bytes 1776 bytes 228680 bytes 1257956 bytes
+624 bytes +0 bytes +8 bytes +0 bytes +8 bytes +624 bytes
+0.1 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yaya-Cout Yaya-Cout Yaya-Cout left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devdl11 @Yaya-Cout