little fix with key EE #320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculator crash when this key is pressed if an app like rpn, reader, or other, is not present so will use the constant APPS_CONTAINER_SNAPSHOT_COUNT to know index of settings. **Note :** I haven't tested the case where it could always select the last of apps, if there are external ones. I don't know if this variable also counts external apps, but I see it used above, so why not use it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculator crash when this key is pressed and if an app like rpn, reader, or other, is not present so will use the constant APPS_CONTAINER_SNAPSHOT_COUNT to know index of settings.
Note : I haven't tested the case where it could always select the last of apps, if there are external ones. I don't know if this variable also counts external apps, but I see it used above, so why not use it.
EDIT: I tested this case and is work perfectly, the key always open settings even 1 or more apps is not present. 😉