Update uploadFilesForDatasetDocuments to Conditionally Upload and Return Status
#493
Conversation
- Add `updateMissing` option to skip existing files - Return success status and message from the function - Improve error handling to report the first error in serial mode
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| files_to_upload = struct('uid',{},'bytes',{},'file_path',{},'is_uploaded',{}); | ||
| for i=1:numel(file_manifest) | ||
| if ~isKey(remote_files, file_manifest(i).uid) | ||
| files_to_upload(end+1) = file_manifest(i); |
Check notice
Code scanning / Code Analyzer
Variable appears to change size on every loop iteration. Consider preallocating for speed. Note
stevevanhooser
deleted the
feature-update-upload-files-for-dataset-documents
branch
This change updates the
ndi.cloud.sync.internal.uploadFilesForDatasetDocumentsfunction to improve its functionality and error reporting. It introduces a newupdateMissingoption that, when enabled, checks the remote dataset for existing files and uploads only those that are missing. Additionally, the function now returns a boolean success status and an accompanying message to provide clearer feedback on the operation's outcome. Error handling has also been improved to ensure that in serial upload mode, only the first error is reported, preventing subsequent error messages from overwriting the original one.PR created automatically by Jules for task 15524481586908157180