Improved completions (#313)

This commit adds specific completions for selected names and attributes. It also extends the completion capabilities to entities, packages and package bodies (previously, this was only possible in architectures). Furthermore, all visible symbols from entities, packages and architectures are included for the generic completion provider. Previously, only symbols in the declarative part of architectures were includes.

vhdl_lang/src/analysis/declarative.rs

@@ -64,7 +64,7 @@ impl Declaration {
                     | View(_)
             ),
             // LRM: package_body_declarative_item
-            AnyEntKind::Design(Design::PackageBody | Design::UninstPackage(..))
+            AnyEntKind::Design(Design::PackageBody(..) | Design::UninstPackage(..))
             | AnyEntKind::Overloaded(
                 Overloaded::SubprogramDecl(_)
                 | Overloaded::Subprogram(_)
@@ -1173,11 +1173,11 @@ fn get_entity_class(ent: EntRef) -> Option<EntityClass> {
         AnyEntKind::Library => None,
         AnyEntKind::Design(des) => match des {
             Design::Entity(_, _) => Some(EntityClass::Entity),
-            Design::Architecture(_) => Some(EntityClass::Architecture),
+            Design::Architecture(..) => Some(EntityClass::Architecture),
             Design::Configuration => Some(EntityClass::Configuration),
             Design::Package(_, _) => Some(EntityClass::Package),
             // Should never be target of attribute
-            Design::PackageBody => None,
+            Design::PackageBody(..) => None,
             Design::UninstPackage(_, _) => None,
             Design::PackageInstance(_) => None,
             Design::InterfacePackageInstance(_) => None,

vhdl_lang/src/analysis/design_unit.rs

@@ -278,7 +278,11 @@ impl<'a, 't> AnalyzeContext<'a, 't> {
             self.ctx,
             &mut unit.ident,
             primary.into(),
-            AnyEntKind::Design(Design::Architecture(primary)),
+            AnyEntKind::Design(Design::Architecture(
+                Visibility::default(),
+                Region::default(),
+                primary,
+            )),
             src_span,
             Some(self.source()),
         );
@@ -294,6 +298,15 @@ impl<'a, 't> AnalyzeContext<'a, 't> {
         self.analyze_declarative_part(&scope, arch, &mut unit.decl, diagnostics)?;
         self.analyze_concurrent_part(&scope, arch, &mut unit.statements, diagnostics)?;
         scope.close(diagnostics);
+
+        let region = scope.into_region();
+        let visibility = root_scope.into_visibility();
+
+        unsafe {
+            arch.set_kind(AnyEntKind::Design(Design::Architecture(
+                visibility, region, primary,
+            )))
+        }
         Ok(())
     }
 
@@ -334,7 +347,10 @@ impl<'a, 't> AnalyzeContext<'a, 't> {
             unit.ident.name().clone().into(),
             Some(self.work_library()),
             Related::DeclaredBy(primary.into()),
-            AnyEntKind::Design(Design::PackageBody),
+            AnyEntKind::Design(Design::PackageBody(
+                Visibility::default(),
+                Region::default(),
+            )),
             Some(unit.ident_pos(self.ctx).clone()),
             unit.span(),
             Some(self.source()),
@@ -355,6 +371,10 @@ impl<'a, 't> AnalyzeContext<'a, 't> {
 
         self.analyze_declarative_part(&scope, body, &mut unit.decl, diagnostics)?;
         scope.close(diagnostics);
+        let region = scope.into_region();
+        let visibility = root_scope.into_visibility();
+
+        unsafe { body.set_kind(AnyEntKind::Design(Design::PackageBody(visibility, region))) }
         Ok(())
     }
 
@@ -647,6 +667,11 @@ impl<'a, 't> AnalyzeContext<'a, 't> {
                         "Use clause must be a selected name",
                         ErrorCode::MismatchedKinds,
                     );
+                    // We still want to resolve the name,
+                    // so that it is available for completion purposes.
+                    // We ignore the errors here, since there is already a diagnostic at that position.
+                    let mut empty_diag = Vec::new();
+                    let _ = self.name_resolve(scope, name.span(), &mut name.item, &mut empty_diag);
                     continue;
                 }
             }

vhdl_lang/src/analysis/root.rs

@@ -475,7 +475,7 @@ impl DesignRoot {
                                 )
                             }
                             // Find all architectures which implement the entity
-                            AnyEntKind::Design(Design::Architecture(ent_of_arch)) => {
+                            AnyEntKind::Design(Design::Architecture(.., ent_of_arch)) => {
                                 ent_of_arch.id == ent_id
                             }
                             _ => false,

vhdl_lang/src/analysis/tests/util.rs

@@ -83,7 +83,10 @@ end architecture;"
 
         for (library_name, codes) in self.libraries.iter() {
             for code in codes {
-                root.add_design_file(library_name.clone(), code.design_file());
+                root.add_design_file(
+                    library_name.clone(),
+                    code.design_file_diagnostics(&mut diagnostics),
+                );
             }
         }
         root.analyze(&mut diagnostics);