Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Enable type attributes #186

Merged
merged 6 commits into from
Sep 8, 2023

Conversation

Schottkyc137
Copy link
Contributor

@Schottkyc137 Schottkyc137 commented Aug 11, 2023

Closes #184

Implementation details:
Introduces a new return type AttrResolveResult which is either a type (for attributes such as 'subtype, 'element) or a value (for most other attributes such as 'high, 'low, ...)

Based on this attribute the name can be resolved correctly and a'subtype'high will resolve to the correct type while a'subtype as an expression yields an error

@Schottkyc137 Schottkyc137 changed the title Enable type attributes Feat: Enable type attributes Aug 12, 2023
@Schottkyc137
Copy link
Contributor Author

Note: Also related to #147 since a type_mark can now simply be parsed as name (as opposed to a selected_name) as resolve_name now correctly resolves type of a name. The only "problematic" thing is the diagnostic handling in the AnalyzeContext (EvalResult vs AnalyzeResult).

@kraigher kraigher merged commit 36c9ca7 into VHDL-LS:master Sep 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Errors reported when using consecutively following attributes
2 participants