Shutdown the server on shutdown request using connection.handle_shutdown.

[Rutherther]

I noticed in an example in rust-analyzer repository: https://github.com/rust-lang/rust-analyzer/blob/master/lib/lsp-server/examples/goto_def.rs#L86C31-L86C46 that there is a handle_shutdown method that does a little more than what vhdl_ls currently did. Using this method also fixes #194 thanks to not actually deserializing the request - so it kind of works around the problem, so probably not the best solution.

It looks like the parameters of the shutdown request that are sent are: {}, this gets parsed into Map instead of unit - ().

[kraigher]

I wrote a comment on the MR, but overall looks ok. I see the CI fails, it is because github upgraded the rust version which introduces new cargo fmt and clippy errors. I fixed those on master so you could rebase on master to get green branch.

[Rutherther]

Hello, sorry for the delay, I somehow missed the comment. Unfortunately, I do not see your comment on the MR. I rebased onto master.

[kraigher]

Should this code be in the else-branch of the if shutdown above?

[Rutherther]

Yeah, that seems better than the current solution. I have removed the break; and added else-branch with handle_request. Is this okay from your side? I have tested this in emacs and works okay, doesn't err on shutdown as it did before.

[kraigher]

Looks good

[kraigher]

I forgot to publish the comment. Now it is published.

[Rutherther]

Should I write a unit test that would send {} instead of empty body to make sure this is covered in the future? I am also not sure what the correct behavior should be when {} is received. Is this a bug on the client, or can an empty body be signaled using {}, and it's bug of the command parser then?

[Rutherther]

Sorry, forgot to run fmt 🤦‍♂️, I always forget.

[kraigher]

I do not think a unit test is necessary in this codebase. Since the deserialization of JSON RPC messages is handled by a third party library. It would be up to this library to support every legal shutdown request format (or be tolerant to slightly malformed messages).