Avoid sending all diagnostics on every file change #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the server now first send the clear diagnostics message before publishing new ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #210
This PR implements a server-side diagnostic cache, containing analysed diagnostics. On every change, new diagnostics are evaluated on the server side. Only when the diagnsotics are not in the cache are they then sent to the client.
This means that there are typically less transactions between server and client.
I'm not quite sure whether this resolves some of the performance impact seen by sending too many diagnostics as the server now has to do a lot of comparisons to check whether the diagnostics are in the cache.