Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to react router #9

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

move to react router #9

wants to merge 8 commits into from

Conversation

beasteers
Copy link
Collaborator

@beasteers beasteers commented Sep 12, 2022

Updated:

it uses react router to manage which recording or recipe you're looking at (e.g. /recordings/coffee-test-1).

The recording menu will automatically open to coffee-test-1, and the dropdown was replaced with a drawer that contains more information about the recordings
image

and any view of the recording will have a URL like this
image
(the recording view looks the same)

Recipe List page

The recipe list will automatically open to pinwheels.
image
image

Main changes:

  • added react-router-dom as dependency
  • added a couple rest API variants useGetRecipe, useGetAllRecordingInfo
  • replaced tabs with buttons in the MUI app bar (I was having trouble getting tabs to work with react-router)
  • added recording selection drawer
  • use the URL to determine which recording/recipe to look at
  • moved the login page to its own file and call it in the main router instead of in individual views

@beasteers beasteers requested a review from soniacq September 12, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant