Add new OPAL-RT Asynchronous Process node-type #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stv0g
force-pushed
the
node-opal-async
branch
2 times, most recently
from
92c2295 to
cc0f7d3
Compare
|
I didn't review, because the CI is failing. |
n-eiling
previously approved these changes
Aug 20, 2025
lib/empty.cpp
Outdated
| @@ -0,0 +1,7 @@ | |||
| /** An empty file | |||
There was a problem hiding this comment.
Why do you need this? Can you add more comment to explain?
lib/nodes/opal_async.cpp
Outdated
| static std::string | ||
| shmemSystemCtrlName; // Shared Memory identifiers and size, provided via argv or config. | ||
| static size_t | ||
| shmemAsyncSize; // Shared Memory identifiers and size, provided via argv or config. |
There was a problem hiding this comment.
The line breaks are a bit weird. Consider moving the comment above the declarations.
|
Blocked by #952 |
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
… Asynchronous process in OPAL-RT's RT-LAB Signed-off-by: Steffen Vogel <[email protected]>
al3xa23
approved these changes
Sep 2, 2025
| opal_async_node1 = { | ||
| type = "opal.async" | ||
|
|
||
| ### The following settings are specific to the opal.async node-type!! ### |
There was a problem hiding this comment.
Only minor thing: I thought the comments are just one # in the beginning?
| # The Send/Recv ID of the RT-Lab OpAsyncSend/Recv blocks. | ||
| id = 1 | ||
|
|
||
| in = { |
There was a problem hiding this comment.
What about the out (sending values back, not only the acknowledgment)?
| #include <spdlog/sinks/base_sink.h> | ||
|
|
||
| // Define RTLAB before including OpalPrint.h for messages to be sent | ||
| // to the OpalDisplay. Otherwise stdout will be used. */ |
There was a problem hiding this comment.
Only minor thing: remove */ at the end of line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new node-type for interfacing VILLASnode as an Asynchronous Process with OPAL-RT's RT-LAB software platform.
See: