Replace react-fullscreenable with a custom hook #458
Merged
+237
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m TrafficLight component added custom TrafficLight implementation uninstalled react-trafficlight package and removed all of its imports additionally, adjusted useEffect hook inside timeoffset widgets to update only on necessary prop updates Signed-off-by: Andrii Podriez <[email protected]>
…tom fullscreen hook implemented custom useFullscreen hook wrapping standard Fullscreen API uninstalled react-fullscreenable package and removed all of its imports Signed-off-by: Andrii Podriez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on "react-fullscreenable", which is no longer maintained and does not support newer React versions.
Changes included:
changes are only relevant for dashboard.jsx, since it is the one that is being rendered for the dashboard page.