ci: Check release target tuplesワークフローを追加#1012
Merged
qryxip merged 7 commits intoVOICEVOX:mainfrom Mar 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR adds a new GitHub Actions workflow that checks if the release target tuples defined in deny.toml match the configuration in the build_and_deploy workflow.
- Introduces a workflow file to validate consistency between deny.toml and build_and_deploy.yml.
- Downloads and installs a specific version of go-yq v4 for processing YAML files.
- Uses shell commands to extract and compare target tuples between the two configuration files.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/check-release-target-tuples.yml | New workflow to check that the release target tuples across configurations are consistent. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/check-release-target-tuples.yml:22
- The script does not handle the scenario where no valid tag is found. Consider adding a check to ensure that 'tag' is non-empty before attempting to download.
tag=$(
gh release ls -R mikefarah/yq --json tagName,isPrerelease \
.github/workflows/check-release-target-tuples.yml:37
- [nitpick] The extraction of 'targets' relies on a specific YAML structure in build_and_deploy.yml. It might be beneficial to add documentation or a safeguard to ensure the structure remains consistent.
targets=$(yq -ro json '.jobs.config.steps[] | select(.id == "strategy_matrix").run' ./.github/workflows/build_and_deploy.yml)
Refs: VOICEVOX#1012 (comment) Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
This reverts commit f07c025.
This reverts commit 71a4455.
qryxip
added a commit
to qryxip/voicevox_core
that referenced
this pull request
Mar 13, 2025
qryxip
added a commit
that referenced
this pull request
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
#1006 の副産物。deny.tomlのこの部分をテストする。
voicevox_core/deny.toml
Lines 2 to 14 in 60790a1
See-also: rust-lang/rust#125579
See-also: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/--print.20host.5B-tuple.7C-triple.5D/near/452327295
関連 Issue
その他