fix: 댓글 알림에 parentCommentId 필드 추가 - #57
Merged
Merged
Conversation
s26047-code
requested review from
1ub7,
devlearner2804,
hikeong and
sooooooobinn
August 20, 2026 14:34
devlearner2804
approved these changes
Aug 20, 2026
1ub7
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
구현 내용
parentCommentId필드 추가변경 사항
NotificationResponseDto에parentCommentId필드 추가NotificationService.toResponseDtos()에서commentId목록으로Comment일괄 조회 후parent.id매핑 (N+1 방지)NotificationResponseDto.from()시그니처에Comment파라미터 추가변경된 API
GET /alarm/comment— 응답에parentCommentId필드 추가parentCommentId가null이면 일반 댓글, 값이 있으면 답글(해당 값은 부모 댓글 id)처리 방식
Comment.parent가null이 아닌 경우에만parentCommentId에 부모 댓글 id를 채워 반환commentId가null)은parentCommentId도 자동으로null반환테스트 방법
parentCommentId가null로 내려오는지 확인한다.parentCommentId에 부모 댓글 id가 정상적으로 채워지는지 확인한다.commentId,parentCommentId모두null로 내려오는지 확인한다.참고사항
commentId필드는 그대로 유지되며, 답글 필드인parentCommentId만 추가했습니다.