Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <C-i> Vim keybinding for Normal mode #8767

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

smlrods
Copy link

@smlrods smlrods commented Dec 6, 2023

What this PR does / why we need it:

This PR addresses an issue with the key binding for <C-i> in Vim Normal mode. The extension already uses Normal mode, but the key binding was not restricted to it. Additionally, this key binding conflict with the Copilot extension, leading to unintended interactions. The proposed change adds a condition to ensure that the key binding is only active in Normal mode, resolving these issues.

Which issue(s) this PR fixes

#8418

Special notes for your reviewer:

  • The extension already operates in Normal mode, and this key binding was unintentionally affecting Visual and Insert modes.
  • The change ensures that the key binding is now restricted to Vim Normal mode, preventing unintended interactions.
  • This modification also resolves a key binding conflict with the Copilot extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants