Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #9006 easymotionDimColor has no effect #9059

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

HenryTSZ
Copy link
Contributor

@HenryTSZ HenryTSZ commented Jun 6, 2024

What this PR does / why we need it:

fixes #9006 easymotionDimColor has no effect

Which issue(s) this PR fixes

#9006

Special notes for your reviewer:

This static property is initialized immediately when the class is loaded (due to the nature of static properties in TypeScript/JavaScript), not when an instance of the class is created. it only depends on the file containing the class (easymotion.ts) being processed by the JavaScript runtime.

private static readonly fade = vscode.window.createTextEditorDecorationType({
color: configuration.easymotionDimColor,
});

So, when we used import, this value is initialized

import { EasyMotion } from '../actions/plugins/easymotion/easymotion';

But at this time, the configuration.asymotionDimColor has not been loaded yet

Vim/extensionBase.ts

Lines 101 to 102 in 0e1e487

// before we do anything else, we need to load the configuration
await loadConfiguration();

Copy link
Member

@J-Fields J-Fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@J-Fields J-Fields merged commit f59aef6 into VSCodeVim:master Jun 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

easymotionDimColor has no effect
2 participants