fixes #8975 The literal string "<leader>" is substituted for the leader key when repeating a command-line command #9075
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the leader key when repeating a command-line command
J-Fields
reviewed
Jun 30, 2024
| @@ -56,7 +56,7 @@ export class RecordedState { | |||
| this.commandList.length > 0 | |||
| ) { | |||
| // Used for the registers and macros that only record on commandList | |||
There was a problem hiding this comment.
Let's clarify & expand this comment - it's not obvious why we're doing this early return.
|
Can you please write a test case for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fixes #8975 The literal string "" is substituted for the leader key when repeating a command-line command
Which issue(s) this PR fixes
#8975
Special notes for your reviewer:
The commandList here saves the ex command, which typically do not include leader.
Vim/src/state/recordedState.ts
Lines 58 to 59 in 5365305
Therefore, we do not need the following replace
Vim/src/state/recordedState.ts
Lines 62 to 64 in 5365305