Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Enterprise support #1926

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

lex-ibm
Copy link
Contributor

@lex-ibm lex-ibm commented Jun 11, 2024

Adds support for using this repo in a private Github Enterprise instance.

@lex-ibm
Copy link
Contributor Author

lex-ibm commented Jun 11, 2024

I did not include the SHOULD_BUILD_TAR="${SHOULD_BUILD_TAR:-no}" changes. I don't think those affect the current build process but given the script is not meant to be used like that I don't see the case.

check_tags.sh Show resolved Hide resolved
@daiyam
Copy link
Member

daiyam commented Jun 11, 2024

I did not include the SHOULD_BUILD_TAR="${SHOULD_BUILD_TAR:-no}" changes. I don't think those affect the current build process but given the script is not meant to be used like that I don't see the case.

Yep, it doesn't affect the VSCodium's build process. So it's up to you.

@lex-ibm
Copy link
Contributor Author

lex-ibm commented Jun 11, 2024

I'll change my pipeline instead. I don't want to change how check_tags.sh works other than adding GitHub Enterprise support.

@daiyam
Copy link
Member

daiyam commented Jun 11, 2024

LGTM

@daiyam
Copy link
Member

daiyam commented Jun 11, 2024

OH! A last thought, wouldn't GITHUB_HOST be better than GH_HOST?

@daiyam
Copy link
Member

daiyam commented Jun 11, 2024

OH! A last thought, wouldn't GITHUB_HOST be better than GH_HOST?

Can you make the change?

@lex-ibm
Copy link
Contributor Author

lex-ibm commented Jun 11, 2024

OH! A last thought, wouldn't GITHUB_HOST be better than GH_HOST?

Can you make the change?

GH_HOST comes from the GitHub CLI documentation.

@lex-ibm
Copy link
Contributor Author

lex-ibm commented Jun 11, 2024

Changing GH_HOST to GITHUB_HOST would mean changing the calls to gh adding the --hostname flag.

@daiyam
Copy link
Member

daiyam commented Jun 11, 2024

GH_HOST comes from the GitHub CLI documentation.

Ah!

When I see git remote add origin "https://${GITHUB_USERNAME}:${GITHUB_TOKEN}@${GH_HOST}/${VERSIONS_REPOSITORY}.git" &> /dev/null, GH_HOST becomes an outlier.

Changing GH_HOST to GITHUB_HOST would mean changing the calls to gh adding the --hostname flag.

Ok. Let's go like that.

@daiyam daiyam merged commit 0c31a54 into VSCodium:master Jun 11, 2024
21 checks passed
@daiyam
Copy link
Member

daiyam commented Jun 11, 2024

@lex-ibm Thanks

@lex-ibm
Copy link
Contributor Author

lex-ibm commented Jun 11, 2024

@daiyam thank you! I'll work on getting those electron binaries out.

@lex-ibm lex-ibm deleted the feature/github-enterprise branch June 11, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants