-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge for v0.9.0 #43
Merge for v0.9.0 #43
Conversation
I will try to find the time to do it in the next couple of days :) |
describe bindings works fine, even though I don't like the name. I was expecting to get an "explanation" of the item when I pressed enter, instead it was executed. I didn't undestand how to try zen mode. Can you add some steps in the changelog? repeats works! |
FWIW icon support seems to break for transient bindings (I think), see #41 (comment) |
Thanks for helping out @MarcoIeni.
The describeBindings name was the expanded name of
Currently, there's no default shortcut from us. A user will have to setup their own shortcut for now. For example: {
"key": "ctrl+z",
"command": "whichkey.toggleZenMode",
"when": "transientVisible"
} Will add a snippet to changelog later this week.
Replied in the issue, and will implement/fix it before this version is released. |
|
whichkey.register: will now accept string for "bindings", and "overrides" in addition to the array. Array is deprecated will be phased out in the future.
- Added `command` as possible value for transient binding item to simplify specifying single command transient item. - Changed how transient menu config are specified. Instead of letting user to specify the bindings of a transient menu in other section of config, user can specify the whole transient menu config in other section of config.
Forced pushed with following major changes
|
Great! I think that if The-Compiler tried it we can merge it :) |
Merged! Thank you everyone. Will release the new version over the weekend if there's no other pressing issue. |
One thing I noticed is that the extensions are still marked Maybe that should be lifted? Or is that something you'd rather do for a v1.0.0 release? |
Yes and I don't think we are at the point we can call v1.0 yet. We are moving there for sure, I think once we tackle the layer problem, we should be in a pretty good spot. Preview is to at least signal API can changed ;) |
This release has been in the works for a while, and I think it's about time to merge to master then release it soon after. The changes are documented in CHANGELOG.
Once merge, we should able to close out
#41
#27
#13
#12
@MarcoIeni Would love to have you look at the CHANGELOG and the try it out?