Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge for v0.9.0 #43

Merged
merged 45 commits into from
Jun 18, 2021
Merged

Merge for v0.9.0 #43

merged 45 commits into from
Jun 18, 2021

Conversation

stevenguh
Copy link
Member

This release has been in the works for a while, and I think it's about time to merge to master then release it soon after. The changes are documented in CHANGELOG.

Once merge, we should able to close out
#41
#27
#13
#12

@MarcoIeni Would love to have you look at the CHANGELOG and the try it out?

@stevenguh stevenguh requested a review from MarcoIeni June 6, 2021 23:38
@MarcoIeni
Copy link
Member

I will try to find the time to do it in the next couple of days :)

CHANGELOG.md Outdated Show resolved Hide resolved
@MarcoIeni
Copy link
Member

MarcoIeni commented Jun 7, 2021

icon support works fine
image


describe bindings works fine, even though I don't like the name. I was expecting to get an "explanation" of the item when I pressed enter, instead it was executed.
Maybe something like "search binding by name"?


I didn't undestand how to try zen mode. Can you add some steps in the changelog?


repeats works!

@The-Compiler
Copy link
Contributor

FWIW icon support seems to break for transient bindings (I think), see #41 (comment)

@stevenguh
Copy link
Member Author

stevenguh commented Jun 8, 2021

Thanks for helping out @MarcoIeni.

describe bindings works fine, even though I don't like the name. I was expecting to get an "explanation" of the item when I pressed enter, instead it was executed.
Maybe something like "search binding by name"?

The describeBindings name was the expanded name of descBinds which can search/describe/execute the command. Since the function is basically emulation of descBinds, not sure if there's a better name for it. I guess "searchBindings" would probably works?


I didn't undestand how to try zen mode. Can you add some steps in the changelog?

Currently, there's no default shortcut from us. A user will have to setup their own shortcut for now. For example:

{
	"key": "ctrl+z",
	"command": "whichkey.toggleZenMode",
	"when": "transientVisible"
}

Will add a snippet to changelog later this week.


ms to break for transient bindings (I think), see #41 (comment)

Replied in the issue, and will implement/fix it before this version is released.

@MarcoIeni
Copy link
Member

I guess "searchBindings" would probably works?
Yes, I think it is mot explanatory

@stevenguh
Copy link
Member Author

Forced pushed with following major changes

  1. Changed the command name describeBindings to searchBindings
  2. Added an example shortcuts for enabling zen mode in transient mode
  3. Implemented icons for transient
  4. Update README with the suggestion, and add period at the end of all bullet point to be consistent.

@MarcoIeni
Copy link
Member

Great! I think that if The-Compiler tried it we can merge it :)

@stevenguh stevenguh merged commit 1b987c3 into master Jun 18, 2021
@stevenguh stevenguh deleted the refactoring branch June 18, 2021 03:08
@stevenguh
Copy link
Member Author

Merged! Thank you everyone. Will release the new version over the weekend if there's no other pressing issue.

@The-Compiler
Copy link
Contributor

One thing I noticed is that the extensions are still marked "preview": true in package.json and thus in the marketplace:

image

Maybe that should be lifted? Or is that something you'd rather do for a v1.0.0 release?

@stevenguh
Copy link
Member Author

Yes and I don't think we are at the point we can call v1.0 yet. We are moving there for sure, I think once we tackle the layer problem, we should be in a pretty good spot. Preview is to at least signal API can changed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants