Absence edit #76
Merged
Absence edit #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # MyBachelor.pro.user # coordinator.cpp # coordinator.hpp # schedule.cpp
| myWindow->show(); | ||
| } | ||
|
|
||
|
|
||
| void Coordinator::showMenuWindow() { | ||
| if (!menuWin) { |
There was a problem hiding this comment.
@VWasser Found out that this code was never called. Why? Because menuWin is never NULL, you initialise it in Coordinator::Coordinator and never delete it.
| //absence signal recieved | ||
|
|
||
| // Not calling, don't know why | ||
| QObject::connect(coordinator, &Coordinator::sendScheduleAbsence, this, [&](){ |
There was a problem hiding this comment.
@VWasser Now I know, why, coordinator was NULL at this line, moved it inside Coordinator.
RomanPodymov
force-pushed
the
absence_edit
branch
from
8c6f334 to
8189d49
Compare
VWasser
force-pushed
the
absence_edit
branch
from
f3aed82 to
a9c3fd3
Compare
|
closed issue #66 |
RomanPodymov
requested changes
Feb 19, 2025
| QObject::connect(abscWin, &absenceWindow::scheduleAbsenceOpened, this, [&](){ | ||
| emit scheduleAbsenceSend(); | ||
| }); | ||
| windows[Screen::SignIn] = signInWindow; |
coordinator.cpp
Outdated
| } | ||
| hideAllScreens(Screen::Schedule); | ||
| } | ||
| void Coordinator::hideAllScreens(Screen exeption){ |
There was a problem hiding this comment.
@VWasser Any questions regarding this function?
There was a problem hiding this comment.
well, nor really, just maybe if there is a way to print out the name of enum elemet so i dont have to print out its adress in the debug SHOWING/HIDING.
RomanPodymov
approved these changes
Feb 20, 2025
…edit # Conflicts: # MyBachelor.pro.user # inputabsence.cpp # schedule.cpp
RomanPodymov
requested changes
Mar 9, 2025
screenwidget.hpp
Outdated
|
|
||
| public: | ||
| ScreenWidget(QWidget *parent = nullptr); // : QWidget(parent) { } | ||
| virtual void configure(ShowBasicData*, ShowBasicData2*) = 0; |
RomanPodymov
requested changes
Mar 9, 2025
screenwidget.hpp
Outdated
| Q_OBJECT | ||
| }; | ||
|
|
||
| struct ShowBasicData2{ |
RomanPodymov
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.