Fix linters

components/dashboard/dashboard.go

@@ -4,7 +4,7 @@
 package dashboard
 
 //
-//import (
+// import (
 //	"context"
 //	"errors"
 //	"fmt"
@@ -24,7 +24,7 @@ package dashboard
 //	"github.com/opendatahub-io/opendatahub-operator/v2/pkg/deploy"
 //)
 //
-//var (
+// var (
 //	ComponentNameUpstream = "dashboard"
 //	PathUpstream          = deploy.DefaultManifestPath + "/" + ComponentNameUpstream + "/odh"
 //
@@ -37,15 +37,15 @@ package dashboard
 //)
 //
 //// Verifies that Dashboard implements ComponentInterface.
-//var _ components.ComponentInterface = (*Dashboard)(nil)
+// var _ components.ComponentInterface = (*Dashboard)(nil)
 //
 //// Dashboard struct holds the configuration for the Dashboard component.
 //// +kubebuilder:object:generate=true
-//type Dashboard struct {
+// type Dashboard struct {
 //	components.Component `json:""`
 //}
 //
-//func (d *Dashboard) Init(ctx context.Context, platform cluster.Platform) error {
+// func (d *Dashboard) Init(ctx context.Context, platform cluster.Platform) error {
 //	log := logf.FromContext(ctx).WithName(ComponentNameUpstream)
 //
 //	imageParamMap := map[string]string{
@@ -65,7 +65,7 @@ package dashboard
 //	return nil
 //}
 //
-//func (d *Dashboard) OverrideManifests(ctx context.Context, platform cluster.Platform) error {
+// func (d *Dashboard) OverrideManifests(ctx context.Context, platform cluster.Platform) error {
 //	// If devflags are set, update default manifests path
 //	if len(d.DevFlags.Manifests) != 0 {
 //		manifestConfig := d.DevFlags.Manifests[0]
@@ -79,18 +79,18 @@ package dashboard
 //	return nil
 //}
 //
-//func (d *Dashboard) GetComponentName() string {
+// func (d *Dashboard) GetComponentName() string {
 //	return ComponentNameUpstream
 //}
 //
-//func (d *Dashboard) ReconcileComponent(ctx context.Context,
+// func (d *Dashboard) ReconcileComponent(ctx context.Context,
 //	cli client.Client,
 //	l logr.Logger,
 //	owner metav1.Object,
 //	dscispec *dsciv1.DSCInitializationSpec,
 //	platform cluster.Platform,
 //	currentComponentExist bool,
-//) error {
+// ) error {
 //	entryPath := DefaultPath
 //	enabled := d.GetManagementState() == operatorv1.Managed
 //	monitoringEnabled := dscispec.Monitoring.ManagementState == operatorv1.Managed
@@ -184,7 +184,7 @@ package dashboard
 //	}
 //}
 //
-//func updateKustomizeVariable(ctx context.Context, cli client.Client, platform cluster.Platform, dscispec *dsciv1.DSCInitializationSpec) (map[string]string, error) {
+// func updateKustomizeVariable(ctx context.Context, cli client.Client, platform cluster.Platform, dscispec *dsciv1.DSCInitializationSpec) (map[string]string, error) {
 //	adminGroups := map[cluster.Platform]string{
 //		cluster.SelfManagedRhods: "rhods-admins",
 //		cluster.ManagedRhods:     "dedicated-admins",
@@ -217,7 +217,7 @@ package dashboard
 //	}, nil
 //}
 //
-//func (d *Dashboard) cleanOauthClient(ctx context.Context, cli client.Client, dscispec *dsciv1.DSCInitializationSpec, currentComponentExist bool, l logr.Logger) error {
+// func (d *Dashboard) cleanOauthClient(ctx context.Context, cli client.Client, dscispec *dsciv1.DSCInitializationSpec, currentComponentExist bool, l logr.Logger) error {
 //	// Remove previous oauth-client secrets
 //	// Check if component is going from state of `Not Installed --> Installed`
 //	// Assumption: Component is currently set to enabled

controllers/components/codeflare_controller.go

@@ -27,7 +27,7 @@ import (
 	componentsv1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/components/v1"
 )
 
-// CodeFlareReconciler reconciles a CodeFlare object
+// CodeFlareReconciler reconciles a CodeFlare object.
 type CodeFlareReconciler struct {
 	client.Client
 	Scheme *runtime.Scheme

controllers/components/dashboard_controller.go

@@ -20,7 +20,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"k8s.io/utils/pointer"
 	"path/filepath"
 
 	appsv1 "k8s.io/api/apps/v1"
@@ -177,11 +176,7 @@ func watchDashboardResources(_ context.Context, a client.Object) []reconcile.Req
 
 var dashboardPredicates = predicate.Funcs{
 	CreateFunc: func(e event.CreateEvent) bool {
-		if e.Object.GetObjectKind().GroupVersionKind().Kind == gvk.Dashboard.Kind {
-			return true
-		}
-		// Reconcile not needed during creation
-		return false
+		return e.Object.GetObjectKind().GroupVersionKind().Kind == gvk.Dashboard.Kind
 	},
 	DeleteFunc: func(e event.DeleteEvent) bool {
 		if e.Object.GetObjectKind().GroupVersionKind().Kind == gvk.Dashboard.Kind {
@@ -368,6 +363,8 @@ func (a *DeployComponentAction) Execute(ctx context.Context, rr *odhtypes.Reconc
 	switch rr.Platform {
 	case cluster.SelfManagedRhods, cluster.ManagedRhods:
 		// anaconda
+		blckownerDel := true
+		ctrlr := true
 		err := cluster.CreateSecret(
 			ctx,
 			rr.Client,
@@ -379,8 +376,8 @@ func (a *DeployComponentAction) Execute(ctx context.Context, rr *odhtypes.Reconc
 				Kind:               rr.Instance.GetObjectKind().GroupVersionKind().Kind,
 				Name:               rr.Instance.GetName(),
 				UID:                rr.Instance.GetUID(),
-				Controller:         pointer.Bool(true),
-				BlockOwnerDeletion: pointer.Bool(true),
+				Controller:         &ctrlr,
+				BlockOwnerDeletion: &blckownerDel,
 			}),
 			cluster.WithLabels(
 				labels.ComponentName, ComponentName,
@@ -394,6 +391,7 @@ func (a *DeployComponentAction) Execute(ctx context.Context, rr *odhtypes.Reconc
 		}
 
 		name = ComponentNameDownstream
+	default:
 	}
 
 	err = deploy.DeployManifestsFromPathWithLabels(ctx, rr.Client, rr.Instance, path, rr.DSCI.Spec.ApplicationsNamespace, name, true, map[string]string{

controllers/components/datasciencepipelines_controller.go

@@ -27,7 +27,7 @@ import (
 	componentsv1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/components/v1"
 )
 
-// DataSciencePipelinesReconciler reconciles a DataSciencePipelines object
+// DataSciencePipelinesReconciler reconciles a DataSciencePipelines object.
 type DataSciencePipelinesReconciler struct {
 	client.Client
 	Scheme *runtime.Scheme

controllers/components/kserve_controller.go

@@ -27,7 +27,7 @@ import (
 	componentsv1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/components/v1"
 )
 
-// KserveReconciler reconciles a Kserve object
+// KserveReconciler reconciles a Kserve object.
 type KserveReconciler struct {
 	client.Client
 	Scheme *runtime.Scheme

controllers/components/kueue_controller.go

@@ -27,7 +27,7 @@ import (
 	componentsv1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/components/v1"
 )
 
-// KueueReconciler reconciles a Kueue object
+// KueueReconciler reconciles a Kueue object.
 type KueueReconciler struct {
 	client.Client
 	Scheme *runtime.Scheme

controllers/components/modelmeshserving_controller.go

@@ -27,7 +27,7 @@ import (
 	componentsv1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/components/v1"
 )
 
-// ModelMeshServingReconciler reconciles a ModelMeshServing object
+// ModelMeshServingReconciler reconciles a ModelMeshServing object.
 type ModelMeshServingReconciler struct {
 	client.Client
 	Scheme *runtime.Scheme

controllers/components/modelregistry_controller.go

@@ -27,7 +27,7 @@ import (
 	componentsv1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/components/v1"
 )
 
-// ModelRegistryReconciler reconciles a ModelRegistry object
+// ModelRegistryReconciler reconciles a ModelRegistry object.
 type ModelRegistryReconciler struct {
 	client.Client
 	Scheme *runtime.Scheme

controllers/components/ray_controller.go

@@ -27,7 +27,7 @@ import (
 	componentsv1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/components/v1"
 )
 
-// RayReconciler reconciles a Ray object
+// RayReconciler reconciles a Ray object.
 type RayReconciler struct {
 	client.Client
 	Scheme *runtime.Scheme

controllers/components/suite_test.go

@@ -14,8 +14,9 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package components
+package components_test
 
+//revive:disable:dot-imports
 import (
 	"path/filepath"
 	"testing"

controllers/components/trainingoperator_controller.go

@@ -27,7 +27,7 @@ import (
 	componentsv1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/components/v1"
 )
 
-// TrainingOperatorReconciler reconciles a TrainingOperator object
+// TrainingOperatorReconciler reconciles a TrainingOperator object.
 type TrainingOperatorReconciler struct {
 	client.Client
 	Scheme *runtime.Scheme

controllers/components/trustyai_controller.go

@@ -27,7 +27,7 @@ import (
 	componentsv1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/components/v1"
 )
 
-// TrustyAIReconciler reconciles a TrustyAI object
+// TrustyAIReconciler reconciles a TrustyAI object.
 type TrustyAIReconciler struct {
 	client.Client
 	Scheme *runtime.Scheme

controllers/components/workbenches_controller.go

@@ -27,7 +27,7 @@ import (
 	componentsv1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/components/v1"
 )
 
-// WorkbenchesReconciler reconciles a Workbenches object
+// WorkbenchesReconciler reconciles a Workbenches object.
 type WorkbenchesReconciler struct {
 	client.Client
 	Scheme *runtime.Scheme

controllers/datasciencecluster/datasciencecluster_controller.go

@@ -83,7 +83,7 @@ const (
 
 // Reconcile is part of the main kubernetes reconciliation loop which aims to
 // move the current state of the cluster closer to the desired state.
-func (r *DataScienceClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { //nolint:maintidx,gocyclo
+func (r *DataScienceClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { //nolint:maintidx
 	log := r.Log
 	log.Info("Reconciling DataScienceCluster resources", "Request.Name", req.Name)
 

main.go

@@ -21,7 +21,6 @@ import (
 	"flag"
 	"os"
 
-	"github.com/hashicorp/go-multierror"
 	addonv1alpha1 "github.com/openshift/addon-operator/apis/addons/v1alpha1"
 	ocappsv1 "github.com/openshift/api/apps/v1" //nolint:importas //reason: conflicts with appsv1 "k8s.io/api/apps/v1"
 	buildv1 "github.com/openshift/api/build/v1"
@@ -81,7 +80,6 @@ var (
 )
 
 func init() { //nolint:gochecknoinits
-
 	utilruntime.Must(componentsv1.AddToScheme(scheme))
 	// +kubebuilder:scaffold:scheme
 	utilruntime.Must(clientgoscheme.AddToScheme(scheme))
@@ -108,22 +106,6 @@ func init() { //nolint:gochecknoinits
 	utilruntime.Must(operatorv1.Install(scheme))
 }
 
-func initComponents(ctx context.Context, p cluster.Platform) error {
-	var errs *multierror.Error
-	var dummyDSC = &dscv1.DataScienceCluster{}
-
-	components, err := dummyDSC.GetComponents()
-	if err != nil {
-		return err
-	}
-
-	for _, c := range components {
-		errs = multierror.Append(errs, c.Init(ctx, p))
-	}
-
-	return errs.ErrorOrNil()
-}
-
 func main() { //nolint:funlen,maintidx
 	var metricsAddr string
 	var enableLeaderElection bool

pkg/controller/actions/action_test.go

@@ -13,18 +13,19 @@ import (
 	"github.com/opendatahub-io/opendatahub-operator/v2/pkg/controller/types"
 )
 
-func NewFakeClient(objs ...ctrlClient.Object) ctrlClient.WithWatch {
+func NewFakeClient(objs ...ctrlClient.Object) ctrlClient.WithWatch { //nolint:ireturn
 	scheme := runtime.NewScheme()
 	utilruntime.Must(corev1.AddToScheme(scheme))
 	utilruntime.Must(appsv1.AddToScheme(scheme))
 
 	fakeMapper := meta.NewDefaultRESTMapper(scheme.PreferredVersionAllGroups())
 	for gvk := range scheme.AllKnownTypes() {
-		switch {
-		// TODO: add cases for cluster scoped
-		default:
-			fakeMapper.Add(gvk, meta.RESTScopeNamespace)
-		}
+		fakeMapper.Add(gvk, meta.RESTScopeNamespace)
+		// switch {
+		//// TODO: add cases for cluster scoped
+		//default:
+		//	fakeMapper.Add(gvk, meta.RESTScopeNamespace)
+		//}
 	}
 
 	return fake.NewClientBuilder().