Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to resolve to another request within retryCondition #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JorgeVV
Copy link
Collaborator

@JorgeVV JorgeVV commented Oct 28, 2020

No description provided.

Copy link

@S0c5 S0c5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a better description for this feature, thanks.

README.md Outdated
@@ -68,6 +68,7 @@ client
| retryCondition | `Function` | `isNetworkOrIdempotentRequestError` | A callback to further control if a request should be retried. By default, it retries if it is a network error or a 5xx error on an idempotent request (GET, HEAD, OPTIONS, PUT or DELETE). |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extends this to add the function to say that receives two parameters (error, context) and should return a boolean otherwise it's going to be handled by the fallback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants