Properly detect whether podman or docker should be used. #8443
+27
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedora ships podman with a podman-docker package that uses a bash script for /usr/bin/docker which runs exec /usr/bin/podman @, This does not work correctly with the current check mechanism in proton's configure script, resulting in invalid permission settings. By checking if the /usr/bin/docker file contains contains 'bin/podman' we can easily determine whether or not to actually use podman before any other checks are done. Signed-off-by: Tom Crider <[email protected]>
Plagman
force-pushed
the
bleeding-edge
branch
28 times, most recently
from
e7f17a1 to
d8c1713
Compare
Plagman
force-pushed
the
bleeding-edge
branch
30 times, most recently
from
b0f64f0 to
2487eb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora ships podman with a podman-docker package that uses a bash script for /usr/bin/docker which runs
exec /usr/bin/podman @, This does not work correctly with the current check mechanism in proton's configure script, resulting in invalid permission settings:By checking if the /usr/bin/docker file contains contains 'bin/podman' we can easily determine whether or not to actually use podman before any other checks are done.