[HL2MP] Adjust melee hit trace #1089
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
► Check if the specific entity can be hit by a melee attack. If the entity cannot be hit, it is ignored. ► If the attacker or the victim is not a combat character (like NPCs), apply the damage to passive entities (like props, objects, etc.).
Bitl
added a commit
to BitlDevelopmentStudios/source-sdk-2013-bds-base
that referenced
this pull request
Mar 18, 2025
Bitl
added a commit
to FIREFIGHT-RELOADED/FIREFIGHT-RELOADED-src-sdk-2013
that referenced
this pull request
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Melee attacks weren't filtering out entities that shouldn't take damage, which leads to situations where melee hits affected immune entities. Additionally, passive entities (like props) weren't getting the right melee damage when neither the attacker nor the victim was a combat character.
Fix:
We added a check to see if an entity can actually be hit by a melee attack before dealing damage, which stops melee strikes from hitting the wrong targets. Now, if neither the attacker nor the victim is a combat character (like NPCs), melee damage is correctly applied to passive entities such as props, making melee interactions with objects in the game more reliable.