[HL2MP] Fix external prop influence #1111
Conversation
► Fixed an issue where prop ownership can be shifted unfairly in certain situations.
| @@ -1050,7 +1050,7 @@ int CBreakableProp::OnTakeDamage( const CTakeDamageInfo &inputInfo ) | |||
| return 1; | |||
| } | |||
|
|
|||
| if( info.GetAttacker() && info.GetAttacker()->MyCombatCharacterPointer() ) | |||
| if ( !IsOnFire() && ToBaseCombatCharacter( info.GetAttacker() ) != NULL ) | |||
| { | |||
| m_hLastAttacker.Set( info.GetAttacker() ); | |||
There was a problem hiding this comment.
Doesn't this already have the intended behavior of setting the last attacker whenever a prop takes damage? Now, if the prop is on fire and get insta-detonated by another player, the credit goes to the person who set the prop on fire
| pAttacker = m_hLastAttacker; | ||
| } | ||
| else if( m_hPhysicsAttacker ) | ||
| if ( HasPhysicsAttacker() ) |
There was a problem hiding this comment.
Why are we overriding m_hLastAttacker with HasPhysicsAttacker()? If Break is called from Event_Kill then this will override the person who actually caused the damage with the person holding the prop with the physgun. If someone is holding an exploding barrel, wouldn't this make them the attacker in this case?
| #endif | ||
| void CBreakableProp::OnBreak( const Vector &, const AngularImpulse &, CBaseEntity * ) | ||
| { | ||
| Remove(); |
There was a problem hiding this comment.
Why are we causing the remove to occur so early? We haven't even finished the Break invocation and we're already destroying the prop? Would having EFL_KILLME be set while the damage handler was still running cause any unexpected behavior?
|
|
||
| // Setup the think function to remove the flags | ||
| RegisterThinkContext( "PROP_CLEARFLAGS" ); | ||
| SetContextThink( &CPhysicsProp::ClearFlagsThink, gpGlobals->curtime, "PROP_CLEARFLAGS" ); |
There was a problem hiding this comment.
Why are we setting a think routine in the same breath we're calling Break?
Issue:
Whenever player 1 tags an explosive prop e.g. uses their pistol to shoot one bullet on an explosive oil drum, which doesn't set it on fire, that barrel has that player 1 as the owner, no matter what happens next. Therefore if that prop is used in the future by player 2 and kills player 3, then player 1 gets the point/frag because the game assumes they are the one who made the kill and shows so in the death notice.
Fix:
Reset prop ownership after 2 seconds if it was not manipulated by anyone after the last interaction.