[TF2] Prevent inspecting weapons in awkward scenarios#1118
Open
Tkain wants to merge 6 commits intoValveSoftware:masterfrom
Open
[TF2] Prevent inspecting weapons in awkward scenarios#1118Tkain wants to merge 6 commits intoValveSoftware:masterfrom
Tkain wants to merge 6 commits intoValveSoftware:masterfrom
Conversation
|
Other weapons should be checked too while at it. At least minigun comes to my mind. |
It has no inspect animation of its own, so the one it uses looks very broken. It's probably better to disable it for now.
Also applies to stickybomb launchers and the Loose Cannon.
Tkain
changed the title
Doing so would also cause the banner to activate after being inspected, which is also likely undesirable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In TF2, multiple weapons can be inspected at times that visually interrupt other actions or lead to the inspect animation being interrupted. One such example is with the flamethrower, whose inspection while being fired make its flames seem to not obey the direction of the flamethrower itself (ignore the background audio, sorry):
Inspecting.flamethrower.while.firing.mp4
This PR adds additional restrictions to when certain weapons can be inspected, preventing players from encountering visual issues like these. Currently, this includes:
This PR addresses some of the issues mentioned in ValveSoftware/Source-1-Games#4273, but does not resolve all of them.