Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF2] Make the respawn timer display "Respawning is not available" for extremely long respawn time #1121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Lizard-Of-Oz
Copy link

@Lizard-Of-Oz Lizard-Of-Oz commented Mar 16, 2025

On certain featured maps (Halloween Arena and VS Saxton Hale) and many community maps respawn is "disabled" by setting the respawn wave time to a very high number (e.g. 99999), but the game still displays it as "Respawning in N seconds...".

This PR makes the game display "Respawning is not available" in such a case, which will add a touch of "legitimacy".
It also hides the respawn countdown from the team composition panel.

This PR requires the addition of a new locale
"game_respawntime_disabled" "Respawning is not available"

Because this PR checks the time left until respawn, mappers shall set the respawn wave time way above 1000 seconds used in this code commit.

One might argue that having a bolted-on value check is "unclean" and a more purposeful solution should be introduced. E.g. an input-keyvalue-netprop combo for tf_gamerules like in my Custom Kill Icons PR. However, it adds extra moving parts that I think are unnecessary, as simply setting the respawn time to a bunch of nines is an intuitive approach even for a novice mapper. It's also a more flexible approach as the respawn timer can be manipulated by the mappers in several ways.

image

@HyperionCoding
Copy link

IMO, using negative values to indicate no respawning would make more sense.

@ficool2
Copy link
Contributor

ficool2 commented Mar 17, 2025

IMO, using negative values to indicate no respawning would make more sense.

This wouldn't accommodate backwards compatibility for maps that use super high respawn times. Should check both <0 and >1000

Bitl added a commit to BitlDevelopmentStudios/source-sdk-2013-bds-base that referenced this pull request Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants