[TF2] Prevent taunting while loading the Beggar's Bazooka

[Tkain]

Description

In TF2, if a player taunts while loading rockets into the Beggar's Bazooka, the loaded rockets will only fire after the taunt finishes playing. Using this with a looping taunt effectively allows a Bazooka user to store their loaded rockets for as long as they want and fire them whenever they want. (This doesn't significantly impact gameplay, but it has been used to troll players in friendly scenarios.)

This PR (edit: partly!) fixes this by not allowing a Bazooka user to taunt while any rockets are loaded into the Bazooka.

This resolves ValveSoftware/Source-1-Games#2703.

[Trico-Everfire]

If I can be honest. This has kinda become an iconic part of TF2. I don't think it particularly hurts anything in casual. it's part of a lot of funny meme strats and is funny if you stack multiple beggars soldiers. Feels kinda weird to fix it tbh.

[BringBackQuickPlay]

https://www.youtube.com/watch?v=gvdf5n-zI14

[Brain-dawg]

You can also do it while taunting with mannrobics and likely other taunts that do special actions on attack, don't need to load before taunting. Blocking taunting while your clip is non-zero wouldn't fix this.

[Tkain]

Well that doesn't mean this fix doesn't work as advertised; the special action bug you mentioned is just a different way of triggering it that needs its own bug fix. (And unfortunately I can't provide that fix because I own no such taunts to test it with.)

[Trico-Everfire]

Well that doesn't mean this fix doesn't work as advertised; the special action bug you mentioned is just a different way of triggering it that needs its own bug fix. (And unfortunately I can't provide that fix because I own no such taunts to test it with.)

Then... Code a trigger for that taunt... You have source code access. Pressing that specific taunt in the menu just triggers code, just call the trigger from elsewhere.

I am also sure there is a way to give yourself that taunt because you should be able to give yourself any weapon/taunt/equipable as how else would one implement custom weapons and such?

[Tkain]

Pressing that specific taunt in the menu just triggers code, just call the trigger from elsewhere.

My goodness, what an idea. Why didn't I think of that?

But seriously, come on. If you'd looked into how it actually works, you'd know that TF2's item system is strongly data-driven to the point where it isn't as simple as just "calling the trigger from elsewhere". It doesn't help that the system for getting the player's inventory currently completely breaks on debug builds. But hey, prove me wrong - you have source code access too.