[All?] Fix exploit allowing color control characters to be used in chat under certain circumstances #1155
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an oversight that causes the
ReadChatTextString
function to skip over color control characters if they are preceded by either of the hex color control codes.This happens because the inner for-loop increments
test
one too many times, causing any following color control characters to be skipped over when the outer for-loop incrementstest
, itself.As far as I can tell, this effects all SDK2013 games.
The following screenshots use the example string
�color!��FFD700test
(0x07636F6C6F7221070546464437303074657374
), generated with https://sourcecolors.neocities.org/