[TF2] Potential fix for chat window out of position in Casual/Competitive Match Start/End #1188
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Match Start + Competitive Summary Adds a check for if player is at end of Casual/Competitive match to retain chat window in lower position. This will minimize overlap with match summary UI on screen. Adds triggers for chat window to raise/lower during match start sequence to minimize overlap with team lineup UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for ValveSoftware/Source-1-Games#3523
Fix is untested due to its dependency on matchmaking
============================
TF2 uses HUD animations (CompetitiveGame_LowerChatWindow and CompetitiveGame_RestoreChatWindow) to handle moving the chat box up and down when the match status doors appear. However, the live TF client triggers CompetitiveGame_RestoreChatWindow whenever a player is respawned, resulting in the chat window moving itself back up to in-game position when players respawn for the match summary.
comp.textbox.bug.mp4
The live client also fails to relocate the chat window at the start of a match to a lower position. This results in some of the match start UI overlapping significantly:
This was previously not an issue in older versions of the game (picture below is from 2016 competitive beta):
Issue is also prevalent in Casual:
Description