[TF2] Fixed Pomson colliding with teammates at close range #1567
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd also like to point out this PR was created at the most unfortunate time, as I initially started writing it mere minutes after the update dropped. |
|
Does this cover any cases that #1232 does not? |
Weird, that one didn't show up when I looked for it when I first looked into this. It does seem much less efficient, spliting up the single if statement into 4 separate ones (which seems a bit excessive) and (also seemingly unnecessarily) checks for it being a player. Other than that it seems like they both achieve the same objective, not sure what the standard is for a situation like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pomson 6000 currently immediately collides with teammates, which makes it absolutely unusable near any teammate. This fix simply makes it behave like other projectiles, such as rockets, which pass through teammates for a short duration after being fired. Does not affect the behaviour on enemy players, nor does it affect the Bison.
Demonstration of how it works with this fix: https://www.youtube.com/watch?v=NR5eppSOFgk
Partially fixes ValveSoftware/Source-1-Games#2592