A remedy to #217 #221
Open
A remedy to #217 #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..not that the wrong one exists for a given build, but..
plohrmann
suggested changes
Mar 31, 2017
| @@ -471,7 +471,7 @@ VoglEditor::Prompt_Result VoglEditor::prompt_generate_trace() | |||
| #endif | |||
|
|
|||
| QString cmdLine = m_pLaunchTracerDialog->get_command_line(); | |||
| QProcessEnvironment env = m_pLaunchTracerDialog->get_process_environment(); | |||
| QProcessEnvironment env = m_pLaunchTracerDialog->get_process_environment (sizeof (void *) < 8); | |||
There was a problem hiding this comment.
Not that it's particularly common, but this means a 64-bit vogleditor could not launch and trace a 32-bit application, because you're only going to inject the 64-bit tracer.
There was a problem hiding this comment.
Absolutely. The problem is, leaving this as-is was breaking the tracing in my case.
There was a problem hiding this comment.
The true answer to this question, IMO, is figuring out how to build a separate, 32-bit tracer using Nix.
There was a problem hiding this comment.
@plohrmann, I have addressed your suggestion (I think)
|
@plohrmann, done! |
deepfire
force-pushed
the
master
branch
2 times, most recently
from
c617f4c to
7c12134
Compare
mgerhardy
reviewed
May 16, 2017
| @@ -348,7 +348,7 @@ bool vogleditor_QApiCallTreeModel::init(vogl_trace_file_reader *pTrace_reader) | |||
| { | |||
| QString msg(QString("*** Information: unpaired \"") + QString(g_vogl_entrypoint_descs[entrypoint_id].m_pName) + QString("\".")); | |||
| vogleditor_output_message(msg.toStdString().c_str()); | |||
| vogl_printf(msg.toStdString().c_str()); | |||
| vogl_printf("%s", msg.toStdString().c_str()); | |||
| vogl_printf("\n"); | |||
There was a problem hiding this comment.
can be merged with the previous line "%s\n"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to remedy #217.