Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[close #273]: Old kernel files are not deleted #281

Merged
merged 1 commit into from
May 6, 2024

Conversation

mirkobrombin
Copy link
Member

This PR makes ABRoot remove unused kernels (both vmlinuz and initrd images) for the new root as the last stage of the transaction.

I tested it by adding a new file called vmlinuz-6.0.6-amd64 to the init partition and then started an update. Only the new kernel used by the new root was kept.

@mirkobrombin mirkobrombin requested review from taukakao and matbme May 6, 2024 14:46
Copy link
Member

@taukakao taukakao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a solution in which we make a folder like init/vos-a-future and switch it with init/vos-a atomically.

But since this is a bug fix, I think it's legitimate. The process can be improved in the future.

@mirkobrombin
Copy link
Member Author

mirkobrombin commented May 6, 2024

I agree, that would be a better solution, I'll make a follow-up (post stable I think) for it when this gets merged

@mirkobrombin mirkobrombin merged commit 6521aeb into main May 6, 2024
5 checks passed
@mirkobrombin mirkobrombin deleted the feat/delete-old-kernels branch May 6, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants