Skip to content

Added favorite feature with toggle and localStorage#47

Open
IshikaBanga26 wants to merge 8 commits intoVarshitha713:masterfrom
IshikaBanga26:add-favorite-button
Open

Added favorite feature with toggle and localStorage#47
IshikaBanga26 wants to merge 8 commits intoVarshitha713:masterfrom
IshikaBanga26:add-favorite-button

Conversation

@IshikaBanga26
Copy link
Copy Markdown

Implemented a favorite button for resource cards using localStorage. Added a toggle to filter and display only favorite items. All changes made inside HTML, CSS, and JavaScript files.

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 31, 2025

Deploy Preview for first-contrib-placement ready!

Name Link
🔨 Latest commit 4db331b
🔍 Latest deploy log https://app.netlify.com/projects/first-contrib-placement/deploys/688f720cb2e7c4000817613e
😎 Deploy Preview https://deploy-preview-47--first-contrib-placement.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread index.html Outdated
Comment on lines 68 to 91
<<<<<<< HEAD
<a href="https://www.edx.org/">Visit codeforces</a>
<button class="fav-btn">☆</button>
</div>
<div class="card" data-id="resource-4" category="learning">
=======
<a href="https://codeforces.com/">Visit codeforces</a>
<p></p>

</div>
<div class="card" category="learning">
>>>>>>> upstream/master
<h4>Learning Git: Git Immersion</h4>
<p>Git Immersion is a guided tour that helps you learn Git through hands-on labs and practical examples.</p>
<a href="https://gitimmersion.com" target="_blank">visit gitimmersion</a>
<button class="fav-btn">☆</button>
</div>
<<<<<<< HEAD

<div class="card" data-id="resource-5" category="coding">
=======
<div class="card" category="coding">
>>>>>>> upstream/master
<h4>Coding Practice: Frontend Mentor</h4>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the merge conflict markers (<<<<<<<, =======, >>>>>>>) were committed by mistake. These need to be removed, and only the correct/combined content should be kept.
@IshikaBanga26

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve removed all conflict markers from index.html.
Please let me know if there’s anything else I need to improve.

@Varshitha713
Copy link
Copy Markdown
Owner

@IshikaBanga26 please check your PR it doesn't contain all the category filters!!

@IshikaBanga26
Copy link
Copy Markdown
Author

Hi! @Varshitha713 , I initially added the favorite button to the existing cards, but it didn’t apply to new ones added later. I’ve now updated the code to make it dynamic — the button will automatically appear on all current and future cards. Let me know if anything else needs updating!

@Varshitha713 Varshitha713 added the needs revision should be modified as requested label Aug 3, 2025
Copy link
Copy Markdown
Owner

@Varshitha713 Varshitha713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

hey @IshikaBanga26 there are many changes to be done for the PR you made it doesn't contain all the updates made to the main (check the deployment)...so wait for a day and then you can work on it after i merge a home page PR!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs revision should be modified as requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants