Skip to content

fix(market): guard execute_fee_rate_change with require_initialized #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akeem813 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(market): guard execute_fee_rate_change with require_initialized #649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions contracts/market/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,6 +1048,13 @@ impl MarketContract {
/// time in [`Self::set_fee_rate`]) so a cap lowered by the admin while a
/// change is in flight cannot let a stale, now-excessive rate through.
pub fn execute_fee_rate_change(env: Env) -> Result<i128, ContractError> {
// Guard: contract must be fully initialized before a pending fee-rate
// change can be applied. Without this check a caller could observe a
// PendingFeeRate entry that was somehow written before initialization
// completed and apply it, writing FeeRateBps storage before the admin
// is set and leaving the contract in an inconsistent state.
validation::require_initialized(&env)?;

let pending = storage::get_pending_fee_rate_change(&env)
.ok_or(ContractError::NoPendingFeeChange)?;
if env.ledger().timestamp() < pending.effective_at {
Expand Down