Skip to content

fix(market): reject deposits at exactly end_time (>= instead of >) #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akeem813 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(market): reject deposits at exactly end_time (>= instead of >) #651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion contracts/market/src/deposit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,16 @@ pub fn deposit_collateral(
return Err(ContractError::MarketClosedToDeposits);
}

if env.ledger().timestamp() > market.end_time {
// Reject deposits at or after end_time. A market expires the moment the
// ledger timestamp reaches end_time, so a deposit submitted in the same
// ledger second as expiry must be rejected (>= not just >).
//
// Using strict greater-than (>) would admit a deposit at exactly
// end_time, which is inside the expired window from the market's
// perspective — the same ledger second is simultaneously the last
// valid trading instant and the first expired one, so we treat it as
// expired and reject it.
if env.ledger().timestamp() >= market.end_time {
return Err(ContractError::MarketExpired);
}

Expand Down