Feat/borrowing - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The lending contract lending/src/lib.rs had several duplicate functions that would have caused compilation errors. I removed:
get_pool_accountingfunctionget_interest_ratefunction that incorrectly tried to read from a non-existent poolborrowfunction that had incomplete token transfer logicrepayfunction that was cut off mid-implementationCurrent State of Key Functions
The contract now maintains only the correct, single implementations of the required functions for the borrowing lifecycle:
get_interest_rate- Properly iterates through all pools to find the asset's pool and returns its interest rateborrow- Validates inputs, accrues interest, checks liquidity, and updates pool accounting correctlyrepay- Processes principal and interest payments, updates accounting properlyget_pool_accounting- Single implementation that accrues interest before returning accounting dataThese functions are now ready to support the borrowing contract's cross-contract calls for the complete collateralized borrowing lifecycle implementation.
closes #78