[IMP] sale_margin_percentage: optimize migration script T#78545 #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisg123v
force-pushed
the
15.0-sale_margin_mig_optimization-luisg
branch
from
83f771e to
9fb5d86
Compare
CLaurelB
approved these changes
Jul 7, 2024
|
LGTM 👍 |
There's a migration script to recompute sales marging on sale order lines, which was raising memory errors with databases that contain many lines. The following optimizations are applied: - Don't call compute method directly but mark the field to be computed. This avoids one write per record and makes the ORM to take care of batches. - Read currency directly from the line, instead of from the pricelist which in turn requires reading the order. - Don't read currency if quantity is zero as it won't be used anyway
luisg123v
force-pushed
the
15.0-sale_margin_mig_optimization-luisg
branch
from
9fb5d86 to
34fc9e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a migration script to recompute sales marging on sale order lines, which was raising memory errors with databases that contain many lines.
The following optimizations are applied: