[FIX] product_cost_usd: order in recompute purchase price I#26616 #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sale_stock_margin` module recomputes the purchase price in sale order lines and calls `super()` only over the lines without a stock move related to it. This causes this module to not recompute the lines with stock moves related, leading to incorrect computation of the purchase price. This commit adds the `sale_stock_margin` module as a dependency in order to first run this module compute.
xmglord
force-pushed
the
15.0-consider_new_modules-xmglord
branch
from
1e5d818 to
c226c98
Compare
xmglord
changed the title
|
@JulioSerna please review. cc: @desdelinux |
JulioSerna
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sale_stock_marginmodule recomputes the purchase price in saleorder lines and calls
super()only over the lines without a stockmove related to it. This causes this module to not recompute the lines
with stock moves related, leading to incorrect computation of the
purchase price.
This commit adds the
sale_stock_marginmodule as a dependency inorder to first run this module compute.