[IMP] sale_margin_percentage: make purchase price editable I#26616 #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see the cause-effect relation here. |
xmglord
force-pushed
the
15.0-editable_purchase_price-xmglord
branch
from
6681590
to
c3de3df
Compare
It was not ready :c |
luisg123v
requested changes
Jul 15, 2024
| @@ -7,7 +7,7 @@ class SaleOrderLine(models.Model): | |||
| margin_threshold = fields.Float( | |||
| default=lambda self: self.env.user.company_id.margin_threshold, help="Limit margin set in sales configuration" | |||
| ) | |||
| purchase_price = fields.Float(readonly=True, help="Price purchase of product") | |||
| purchase_price = fields.Float(help="Price purchase of product") | |||
This module was originally created in v11 for a specific customer, and the purchase price needed to be non-editable for some reason. Now the purchase price does not need to be non-editable. If it is needed, it should be managed in the view because the field is natively editable.
xmglord
force-pushed
the
15.0-editable_purchase_price-xmglord
branch
from
c3de3df
to
773ac6e
Compare
luisg123v
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module was originally created in v11 for a specific customer, and
the purchase price needed to be non-editable for some reason. Now the
purchase price does not need to be non-editable. If it is needed, it
should be managed in the view because the field is natively editable.