Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] default_warehouse_from_sale_team: remove incorrect record rule T#79454 #1677

Merged

Conversation

luisg123v
Copy link
Contributor

There was a rule to grant read-only access to pickings. However, the correct way to grant read-only access to a model is to uncheck the "Read" field on the desired rule, which would cause that rule to not be considered when verifying accesses.

Copy link
Contributor

@TeposteAJ TeposteAJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. c:
👍

There was a rule to grant read-only access to pickings. However, the
correct way to grant read-only access to a model is to uncheck the
"Read" field on the desired rule, which would cause that rule to not be
considered when verifying accesses.
@luisg123v luisg123v force-pushed the 17.0-default_warehouse_rm_rule-luisg branch from 9e97638 to 92ec4ab Compare July 27, 2024 01:49
@isaako34
Copy link

LGTM 👍

@luisg123v luisg123v merged commit 92ec4ab into Vauxoo:17.0 Jul 29, 2024
3 checks passed
@luisg123v luisg123v deleted the 17.0-default_warehouse_rm_rule-luisg branch July 29, 2024 19:47
@luisg123v
Copy link
Contributor Author

Thanks a lot @TeposteAJ @isaako34.

@luisg123v luisg123v restored the 17.0-default_warehouse_rm_rule-luisg branch August 27, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants