[FIX] typ: Missing label in routes view #1682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fields for warehouses and manual_Transfers_selectable were placed on a single line. There was no clarity on what they represented, as they were just two checkboxes without the appropriate labels. Therefore, the latter was moved to a separate field and made invisible where it was previously displayed. Related https://git.vauxoo.com/vauxoo/typ/-/issues/484
|
@luisg123v Could you review, please? 🥲 |
luisg123v
requested changes
Aug 29, 2024
| @@ -5,7 +5,7 @@ | |||
| <field name="model">stock.route</field> | |||
| <field name="inherit_id" ref="stock.stock_location_route_form_view" /> | |||
| <field name="arch" type="xml"> | |||
| <xpath expr="//field[@name='warehouse_selectable']" position="after"> | |||
| <xpath expr="//div[field[@name='warehouse_ids']]" position="after"> | |||
There was a problem hiding this comment.
For readability, I think it would be better to reference the selectable field:
Suggested change
| <xpath expr="//div[field[@name='warehouse_ids']]" position="after"> | |
| <xpath expr="//div[field[@name='warehouse_selectable']]" position="after"> |
(I had to check original code to understand this)
|
Superseded by #1683, where the correct source repo was used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields for warehouses and manual_transfers_selectable were placed on a single line. There was no clarity on what they represented, as they were just two checkboxes without the appropriate labels. Therefore, the latter was moved to a separate field and made invisible where it was previously displayed.
Related https://git.vauxoo.com/vauxoo/typ/-/issues/484
Form Routes View.
warehousescheckboxes checked. It doesn't show anything.warehouses&manual_transferscheckboxes checked. There is a single checkbox per line, and each field has its corresponding label, which provides greater clarity.Form Routes View.