[IMP] stock_by_warehouse: Enhance stock visibility for warehouse-Wizard T#79454 #1685

TeposteAJ · 2024-10-21T19:27:54Z

To enhance user comprehension by improving the visibility of stock levels
across different warehouses, especially when creating a sale and checking
stock availability. This feature is particularly useful for managing stock
across multiple locations. Additionally, conditional help tooltips have
been added to assist in correctly interpreting the values, and translation
terms have been updated.

Requisition

Change the aesthetics of the Stock by Warehouse Wizard, which is optionally displayed in sales orders. Only the fields of interest need to be kept, and the structure should be made easier to understand.
Related to: vauxoo/typ#530

Sale order form view (Stock by Warehouse Wizard) :

Before development you have the following default view:
After development you have the following default view:

TeposteAJ · 2024-10-21T19:41:30Z

Hi @luisg123v could you review it ? , please

stock_by_warehouse/i18n/es.po

stock_by_warehouse/static/src/components/warehouse/warehouse_field.xml

rolandojduartem · 2024-10-21T22:28:44Z

stock_by_warehouse/static/src/components/warehouse/warehouse_field.xml

+                            </td>
+                            </tr>
+                        </t>
+                        </t>


There are problems in the indentation

rolandojduartem · 2024-10-21T22:31:03Z

stock_by_warehouse/i18n/es.po

+#, python-format
+msgid "Incoming stock may not cover or will barely meet demand."
+msgstr ""
+"Es posible que el stock entrante no cubra o apenas satisfaga la demanda."


inventario instead of stock

stock_by_warehouse/static/src/components/warehouse/warehouse_field.xml

rolandojduartem · 2024-10-21T22:36:53Z

stock_by_warehouse/static/src/components/warehouse/warehouse_field.xml

+                                        t-att-class="
+                                        line.virtual > 3 ? '' :
+                                        (line.virtual > 0 ? 'text-warning' : 'text-danger')"
+                                    >


Indentation

Suggested change

t-att-class="

line.virtual > 3 ? '' :

(line.virtual > 0 ? 'text-warning' : 'text-danger')"

>

t-att-class="

line.virtual > 3 ? '' :

(line.virtual > 0 ? 'text-warning' : 'text-danger')"

>

rolandojduartem · 2024-10-21T23:14:40Z

Functionally LGTM

stock_by_warehouse/static/src/components/warehouse/warehouse_field.xml

luisg123v · 2024-10-24T02:07:46Z

stock_by_warehouse/static/src/components/warehouse/warehouse_field.xml

+                                    <t t-if="line.virtual gt 0" t-set="saleable_qty_title_message">
+                                        <t> This quantity is available for immediate sale and delivery.</t>
+                                        <t t-out="'\n'" />
+                                        <t> This represents on hand quantity minus the reserved stock.</t>


Just one more matter:

Is it accurate to mention reserved quantity? Be aware, starting from v17.0, the concept of reserved quantity doesn't exist anymore, not as handled in previous versions anyway, see odoo/odoo@7dda6bb9 for more info.

ready!
:o This is important! tks c: @luisg123v

luisg123v · 2024-10-25T02:11:42Z

stock_by_warehouse/static/src/components/warehouse/warehouse_field.xml

+                                </td>
+                                <td style="text-align: center;">
+                                    <t t-if="line.virtual gt 0" t-set="saleable_qty_title_message">
+                                        <t> This quantity is available for immediate sale and delivery.</t>


Sorry for not noticing it before:

Suggested change

<t> This quantity is available for immediate sale and delivery.</t>

<t>This quantity is available for immediate sale and delivery.</t>

Same below.

@luisg123v no worries! No need to apologize 😉. Done!

luisg123v · 2024-10-25T02:12:22Z

Hi @rolandojduartem,

This in general LGTM. Could you review again, please?

Regards,

rolandojduartem · 2024-10-26T03:57:02Z

I like the new style, but in mobile is buggy

Please, in this line https://github.com/Vauxoo/addons-vauxoo/blob/8dc846c4/stock_by_warehouse/static/src/components/warehouse/warehouse_field.esm.js#L78

Modify it to position: localization.direction === "rtl" || isMobileOS() ? "bottom" : "right",

You could import isMobileOS as
import { isMobileOS } from "@web/core/browser/feature_detection";

Currently, you could not see all the information

but, the proposed solution will position the popover at the botton of the field and you can check the information easily.

rolandojduartem · 2024-10-26T03:45:53Z

stock_by_warehouse/static/src/components/warehouse/warehouse_field.xml

+                                </td>
+                                <td style="text-align: center;">
+                                    <t t-if="line.virtual gt 0" t-set="saleable_qty_title_message">
+                                        <t>This quantity is available for immediate sale and delivery.</t>


So, @luisg123v, do we want these messages here?

@luisg123v just this comment for me, if you are OK, so LGTM

@rolandojduartem yes, it's expected. It's the improvement implemented here, showing not only the quantities but also their meaning.

To enhance user comprehension by improving the visibility of stock levels across different warehouses, especially when creating a sale and checking stock availability. This feature is particularly useful for managing stock across multiple locations. Additionally, conditional help tooltips have been added to assist in correctly interpreting the values, and translation terms have been updated.

TeposteAJ · 2024-10-28T16:58:07Z

@rolandojduartem Tks u 4 the improvements, the changes have been added c:

rolandojduartem · 2024-10-28T17:31:43Z

LGTM 👍 @luisg123v

luisg123v

LGTM 👍

luisg123v requested changes Oct 21, 2024

View reviewed changes

luisg123v requested a review from rolandojduartem October 21, 2024 21:06

luisg123v changed the title ~~[IMP] stock_by_warehouse: Enhance stock visibility for warehouse-Wizard~~ [IMP] stock_by_warehouse: Enhance stock visibility for warehouse-Wizard T#79454 Oct 21, 2024

rolandojduartem suggested changes Oct 21, 2024

View reviewed changes

TeposteAJ force-pushed the 17.0-Imp_Wizard_quants-TeposteAJ branch from 097e90b to 65c8b9f Compare October 22, 2024 00:33

TeposteAJ requested review from luisg123v and rolandojduartem October 22, 2024 00:35

TeposteAJ force-pushed the 17.0-Imp_Wizard_quants-TeposteAJ branch 3 times, most recently from 54c758e to d9640c8 Compare October 22, 2024 16:53

luisg123v requested changes Oct 22, 2024

View reviewed changes

stock_by_warehouse/static/src/components/warehouse/warehouse_field.xml Outdated Show resolved Hide resolved

TeposteAJ force-pushed the 17.0-Imp_Wizard_quants-TeposteAJ branch from d9640c8 to 306f91a Compare October 23, 2024 00:36

TeposteAJ requested a review from luisg123v October 23, 2024 00:36

TeposteAJ force-pushed the 17.0-Imp_Wizard_quants-TeposteAJ branch 2 times, most recently from d0d1521 to 52b567a Compare October 23, 2024 15:33

luisg123v requested changes Oct 24, 2024

View reviewed changes

TeposteAJ force-pushed the 17.0-Imp_Wizard_quants-TeposteAJ branch from 52b567a to 832bc2b Compare October 24, 2024 15:54

TeposteAJ requested a review from luisg123v October 24, 2024 17:28

TeposteAJ force-pushed the 17.0-Imp_Wizard_quants-TeposteAJ branch from 832bc2b to 8afba78 Compare October 24, 2024 22:08

luisg123v reviewed Oct 25, 2024

View reviewed changes

TeposteAJ force-pushed the 17.0-Imp_Wizard_quants-TeposteAJ branch from 8afba78 to 51664c0 Compare October 25, 2024 15:37

TeposteAJ requested a review from luisg123v October 25, 2024 22:19

TeposteAJ force-pushed the 17.0-Imp_Wizard_quants-TeposteAJ branch 2 times, most recently from 452f43d to dbd590f Compare October 26, 2024 00:35

rolandojduartem reviewed Oct 26, 2024

View reviewed changes

TeposteAJ force-pushed the 17.0-Imp_Wizard_quants-TeposteAJ branch from dbd590f to f38c703 Compare October 28, 2024 16:37

rolandojduartem approved these changes Oct 28, 2024

View reviewed changes

luisg123v approved these changes Oct 29, 2024

View reviewed changes

luisg123v merged commit 23c94e6 into Vauxoo:17.0 Oct 29, 2024
3 checks passed

luisg123v deleted the 17.0-Imp_Wizard_quants-TeposteAJ branch October 29, 2024 22:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] stock_by_warehouse: Enhance stock visibility for warehouse-Wizard T#79454 #1685

[IMP] stock_by_warehouse: Enhance stock visibility for warehouse-Wizard T#79454 #1685

TeposteAJ commented Oct 21, 2024 •

edited by luisg123v

Loading

TeposteAJ commented Oct 21, 2024

rolandojduartem Oct 21, 2024

rolandojduartem Oct 21, 2024

rolandojduartem Oct 21, 2024

rolandojduartem commented Oct 21, 2024

luisg123v Oct 24, 2024

TeposteAJ Oct 24, 2024

luisg123v Oct 25, 2024

TeposteAJ Oct 25, 2024 •

edited

Loading

luisg123v commented Oct 25, 2024

rolandojduartem commented Oct 26, 2024

rolandojduartem Oct 26, 2024

rolandojduartem Oct 28, 2024

luisg123v Oct 28, 2024

TeposteAJ commented Oct 28, 2024

rolandojduartem commented Oct 28, 2024

luisg123v left a comment

	<t> This quantity is available for immediate sale and delivery.</t>
	<t>This quantity is available for immediate sale and delivery.</t>

[IMP] stock_by_warehouse: Enhance stock visibility for warehouse-Wizard T#79454 #1685

[IMP] stock_by_warehouse: Enhance stock visibility for warehouse-Wizard T#79454 #1685

Conversation

TeposteAJ commented Oct 21, 2024 • edited by luisg123v Loading

Requisition

Sale order form view (Stock by Warehouse Wizard) :

TeposteAJ commented Oct 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rolandojduartem commented Oct 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TeposteAJ Oct 25, 2024 • edited Loading

Choose a reason for hiding this comment

luisg123v commented Oct 25, 2024

rolandojduartem commented Oct 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TeposteAJ commented Oct 28, 2024

rolandojduartem commented Oct 28, 2024

luisg123v left a comment

Choose a reason for hiding this comment

TeposteAJ commented Oct 21, 2024 •

edited by luisg123v

Loading

TeposteAJ Oct 25, 2024 •

edited

Loading