Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] default_warehouse_from_sale_team: validate cache access when no record exists i#28375 #1688

Merged

Conversation

CLaurelB
Copy link
Contributor

@CLaurelB CLaurelB commented Jan 9, 2025

Add a validation to avoid errors when accessing the cache without a record. The change ensures that the team_id value is only retrieved from the cache when a valid account.move record exists.

… record exists

Add a validation to avoid errors when accessing the cache without a
record. The change ensures that the `team_id` value is only retrieved
from the cache when a valid `account.move` record exists.
@CLaurelB
Copy link
Contributor Author

CLaurelB commented Jan 9, 2025

@luisg123v could you review, please?

cc. @desdelinux

Copy link
Contributor

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Could you create a dummy MR in TyP to ensure it's now green, please?

CC @andreagidaltig

@luisg123v luisg123v merged commit 1b236e8 into Vauxoo:17.0 Jan 9, 2025
3 checks passed
@luisg123v luisg123v deleted the 17.0-add_case_when_self_is_empty-CLaurelB branch January 9, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants