Fix selenium crash #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exit code from tests was being masked by the exit codes reported when generating coverage reports which meant that even if tests failed, as long as coverage report generation was succesful, the job would not fail. Therefore the exit code for tests is now stored and used.
With previous resource limits Selenium tests would crash with a "window tab crashed" error message. The new limits match Odoo's limits used for testing[1] and fix said issue. [1] https://github.com/Vauxoo/odoo/blob/9d51fa9d/odoo/tests/common.py#L1003
|
Can you review @moylop260? Also I think the CI is running with the target branch instead of code on my branch (due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to run selenium tests on an Odoo 16 local development instance and selenium would always crash with the following message:
After investigating I was able to track it down to the resource limits that were being used. After setting them to infinity as Odoo does, selenium tests work fine again. Setting them to infinity may look scary but I think that is actually the default value for processes, at least on my machine, also tests are not being run in production to resource limits would not change there.