Fixed typing bug in base detection API

Also updated example script to use full analysis by default
Vector35 · May 3, 2024 · 92a468d · 92a468d
1 parent 8448712
commit 92a468d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/python/basedetection.py b/python/basedetection.py
@@ -161,7 +161,7 @@ def aborted(self) -> bool:
     def detect_base_address(
         self,
         arch: Optional[str] = "",
-        analysis: Optional[str] = Literal["basic", "controlFlow", "full"],
+        analysis: Optional[Literal["basic", "controlFlow", "full"]] = "full",
         min_strlen: Optional[int] = 10,
         alignment: Optional[int] = 1024,
         low_boundary: Optional[int] = 0,

diff --git a/python/examples/raw_binary_base_detection.py b/python/examples/raw_binary_base_detection.py
@@ -47,7 +47,7 @@ def _parse_args() -> argparse.Namespace:
     parser.add_argument("path", help="path to the position-dependent raw firmware binary or directory")
     parser.add_argument("--debug", action="store_true", help="enable debug logging")
     parser.add_argument("--reasons", action="store_true", help="show reasons for base address selection")
-    parser.add_argument("--analysis", type=str, help="analysis level", default="basic")
+    parser.add_argument("--analysis", type=str, help="analysis level", default="full")
     parser.add_argument("--arch", type=str, default="", help="architecture of the binary")
     return parser.parse_args()