Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix leak creation of invalid BinaryView handle #5294

Merged
merged 1 commit into from
May 1, 2024
Merged

fix leak creation of invalid BinaryView handle #5294

merged 1 commit into from
May 1, 2024

Conversation

rbran
Copy link
Contributor

@rbran rbran commented Apr 17, 2024

The parameter view: Option<Ref<BinaryView>> is being dropped by the if let statement, making the handle to it invalid.

This fix the problem with Ref::into_raw.

@plafosse plafosse requested a review from ElykDeer April 17, 2024 17:31
@plafosse plafosse added this to the Elysium milestone Apr 17, 2024
@rssor rssor merged commit e0fb875 into Vector35:dev May 1, 2024
2 checks passed
@rbran rbran deleted the fix-form-input-builder branch May 1, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElykDeer ElykDeer Awaiting requested review from ElykDeer

Assignees

@rssor rssor

Labels
None yet
Projects
None yet
Milestone
4.1 (Elysium)
Development

Successfully merging this pull request may close these issues.
3 participants
@rbran @plafosse @rssor